H3API by RoseKavalier

A while back I modified the way H3Dlg works because passing along a proc as argument is archaic, it now acts more like common C++ UI controls and is generally easier to work with. At some point I will make some overridable controls as well.
I don't know how up to date your api version is but here's an overview of how it now works:

H3Dlg now has its own virtual table where you simply override virtual functions to achieve what you need.

e.g.

Код: Выделить всё

struct MyDlg : H3Dlg
{
   MyDlg(int w, int h) : H3Dlg(w, h) {} // _H3API_ H3Dlg(int width, int height, int x = -1, int y = -1, BOOL statusBar = false, BOOL makeBackground = true, INT32 colorIndex = IntAt(0x69CCF4));

   int m_myValue;

   virtual BOOL OnCreate() override
        {
            m_myValue = 1234;
            return true; // continue running dialog, false to abort
        }
        virtual BOOL OnLeftClick(INT itemId, H3Msg& msg) override
        {
            if (itemId != m_myValue)
            { ...
                return false; // do not process further messages, skips DefaultProc()
            }
            return true; //  goes to DefaultProc()
        }
};


However if you wish to have complete control, you can override vDialogProc which is what provides all these handy overrideable functions in order to implement your own.

After looking at your new headlines, I realized the reason for my mistake. Thanks. I solved the problem.

Moving to the latest H3API - its a real pain
Most of the problems are solved.
Besides that:
1. <P_NewGameDlg>, <CastDef()>:

 

2. <Save>, <Load>:

 

What should I do instead?

And a few clarifications, are these the correct fixes?
1. <H3Msg> create:

 

2.<F_GetCursorPosition->H3POINT::GetCursorPosition>, <H3POINT->POINT>, it looks strange that SimulateMouseOver argument type is <POINT>, instead <H3POINT>:

 

A small addition to the H3API:
<INT32> is better type for <H3RmgZoneGenerator._f_20> and <H3RmgZoneGenerator._f_24>, then <h3unk8 _f_20[4]>:

 

Because <H3RmgZoneGenerator._f_20> is the X coordinate, and <H3RmgZoneGenerator._f_24> is the Y coordinate.

I missed a few changes in the overview I guess
1a- P_SelectScenarioDialog
1b- Cast<H3DlgDef>

2- H3GzFile instead of H3ZStream
z_stream is part of the class, but according to RTTI it was called TGzFile, so renamed closer to reality.

Extras
1 - yes that should do, the other fields are not used anyway.
2 - H3POINT and ::POINT are analogous. I changed it on my development api a while back but it's not yet live, you can do so in

Код: Выделить всё

include/h3api/H3Managers/H3AdventureManager.hpp
include/h3api/H3Managers/H3AdventureManager.cpp

Addition
Sure thing, just wondering the x/y of what? Since [10-18] already has x/y/z.

Thanks!

But having one error:

 

Addition.
It is the lower left vertex of the rectangle described around the zone:

 

Two corrections for bitset (not ready to update the api):

\include\h3api\H3Containers\H3Bitset.hpp : 597

Код: Выделить всё

m_bits[i] = other.m_bits[i];

\include\h3api\H3Containers\H3Bitset.hpp : 611

Код: Выделить всё

if (m_bits[i] != other.m_bits[i])

Is there an easy way to extend the original structure "H3rmgMapItem"?

Цитата:

Is there an easy way to extend the original structure "H3rmgMapItem"?

Если Вам не нужны новые поля, вы можете создать свой класс, наследующий H3rmgMapItem.

Нет, нужно именно добавить несколько своих полей.

Тогда никак. Ваша структура/класс просто не совпадёт по размеру с оригинальной, и без "перелопачивания" всего кода, работающего с этой структурой, не обойтись. Если нужно добавить не очень много полей, можно посмотреть в сторону неиспользуемых в оригинальной структуре (например, из-за выравнивания членов структур могуг оказаться доступными лишние байты для размещения собственных полей):

char a1;
char unk0;
char unk1;
char unk2;

Здесь игра читает a1 как поле типа char, поэтому остальные три можно отдать под свои поля. Но если глобально, то придётся патчить код (те фрагменты, которые используют размер структуры, например, в операциях с указателями).